Re-try package installation on failure #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR mandiant#1274 introduced the consistent creation of `failed_packages.txt` to signal installation completion for automation. However, it also inadvertently caused the installer to always log additional failure information, regardless of actual package failures, because of checking for the existence of the (now always present) file. This commit addresses this by checking the actual count of failed packages (`$failures.Count`). The detailed failure messages are now only displayed when one or more packages have failed to install.
Ana06
added
💎 enhancement
Try to install failed packages after completing all packages installation. This way packages have more chances to get installed, facilitating automated FLARE-VM installations (without manual interaction). Introduces the functions `Get-Failed-Packages` and `Install-Packages` to avoid duplicating code.
d35ha
approved these changes
Apr 25, 2025
|
Thanks for the review @d35ha! 💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to install failed packages after completing all packages installation. This way packages have more chances to get installed,
facilitating automated FLARE-VM installations (without manual interaction).
Introduces the functions
Get-Failed-PackagesandInstall-Packagesto avoid duplicating code.In addition, this PR also fixes a bug introduced in PR #1274 where we started to always create
failed_packages.txtto signal installation completion for automation. It also inadvertently caused the installer to always log additional failure information, regardless of actual package failures, because of checking for the existence of the (now always present) file. The detailed failure messages are now only displayed when one or more packages have failed to install.Closes #1219.
@mandiant/vms I would appreciate a review if anyone has time, as any error in the installer breaks Commando-VM and FLARE-VM. I have tested locally, but an extra pair of 👀 would be good.