[installer.vm] Always create failed_packages.txt #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `failed_packages.txt` is always created (empty if no failures). This provides a predictable file structure for automated build scripts, allowing them to rely on the presence of this file to determine FLARE-VM installation completion.
Ana06
added a commit
to Ana06/VM-Packages
that referenced
this pull request
Apr 24, 2025
PR mandiant#1274 introduced the consistent creation of `failed_packages.txt` to signal installation completion for automation. However, it also inadvertently caused the installer to always log additional failure information, regardless of actual package failures, because of checking for the existence of the (now always present) file. This commit addresses this by checking the actual count of failed packages (`$failures.Count`). The detailed failure messages are now only displayed when one or more packages have failed to install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
failed_packages.txtis always created (empty if no failures). This provides a predictable file structure for automated build scripts, allowing them to rely on the presence of this file to determine FLARE-VM installation completion.