Improve error logging

src/auth/strategies/firebase-admin-user-login.strategy.ts

@@ -1,6 +1,6 @@
 import { Strategy, VerifiedCallback } from 'passport-custom'
 import { PassportStrategy } from '@nestjs/passport'
-import { Injectable, UnauthorizedException } from '@nestjs/common'
+import { Injectable, UnauthorizedException, InternalServerErrorException } from '@nestjs/common'
 import { ExtractJwt } from 'passport-jwt'
 import { Request } from 'express'
 import * as firebaseAdmin from 'firebase-admin'

src/shared/filters/all-exceptions.filter.ts

@@ -0,0 +1,47 @@
+import { ExceptionFilter, Catch, ArgumentsHost, HttpException, HttpStatus } from '@nestjs/common'
+import { AppLogger } from '../logger/logger.service'
+
+@Catch()
+export class AllExceptionsFilter implements ExceptionFilter {
+  constructor(private appLogger: AppLogger) {
+    this.appLogger.setContext(AllExceptionsFilter.name)
+  }
+
+  catch(exception: unknown, host: ArgumentsHost) {
+    const ctx = host.switchToHttp()
+    const response = ctx.getResponse()
+    const request = ctx.getRequest()
+
+    if (exception instanceof HttpException) {
+      const status = exception.getStatus()
+      const errorMessage = exception.getResponse() as HttpException
+
+      const responseObject = {
+        statusCode: status,
+        timestamp: new Date().toISOString(),
+        url: request.url,
+        ...errorMessage,
+      }
+
+      this.appLogger.debug(JSON.stringify({ status, responseObject }))
+      return response.status(status).json(responseObject)
+    }
+
+    // Log the stack for non-HttpException errors
+    if (exception instanceof Error) {
+      this.appLogger.error(exception.message, exception.stack, exception.name)
+    } else {
+      console.log(exception)
+    }
+
+    const status = HttpStatus.INTERNAL_SERVER_ERROR
+    const responseObject = {
+      statusCode: status,
+      timestamp: new Date().toISOString(),
+      url: request.url,
+    }
+
+    this.appLogger.debug(JSON.stringify({ status, responseObject }))
+    return response.status(status).json(responseObject)
+  }
+}

src/shared/interceptors/logging.interceptor.ts

@@ -13,7 +13,7 @@ export class LoggingInterceptor implements NestInterceptor {
     const request = context.switchToHttp().getRequest()
     const method = request.method
     const url = request.originalUrl
-    this.appLogger.debug(`method: ${method} | url: ${url}`)
+    this.appLogger.debug(JSON.stringify({ method, url }))
 
     const now = Date.now()
     return next.handle().pipe(
@@ -22,9 +22,7 @@ export class LoggingInterceptor implements NestInterceptor {
         const statusCode = response.statusCode
 
         const responseTime = Date.now() - now
-        this.appLogger.debug(
-          `method: ${method} | url: ${url} | statusCode: ${statusCode} | responseTime: ${responseTime}ms`
-        )
+        this.appLogger.debug(JSON.stringify({ method, url, statusCode, responseTime }))
       })
     )
   }

src/shared/shared.module.ts

@@ -4,11 +4,18 @@ import { configModuleOptions } from '../shared/config/module-options'
 import { FirebaseModule } from './firebase/firebase.module'
 import { LoggerModule } from './logger/logger.module'
 import { LoggingInterceptor } from './interceptors/logging.interceptor'
-import { APP_INTERCEPTOR } from '@nestjs/core'
+import { APP_INTERCEPTOR, APP_FILTER } from '@nestjs/core'
+import { AllExceptionsFilter } from './filters/all-exceptions.filter'
 
 @Module({
   imports: [ConfigModule.forRoot(configModuleOptions), FirebaseModule, LoggerModule],
-  providers: [{ provide: APP_INTERCEPTOR, useClass: LoggingInterceptor }],
+  providers: [
+    { provide: APP_INTERCEPTOR, useClass: LoggingInterceptor },
+    {
+      provide: APP_FILTER,
+      useClass: AllExceptionsFilter,
+    },
+  ],
   exports: [ConfigModule, FirebaseModule, LoggerModule],
 })
 export class SharedModule {}