Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error logging #100

Merged
merged 3 commits into from
May 3, 2020
Merged

Improve error logging #100

merged 3 commits into from
May 3, 2020

Conversation

yashmurty
Copy link
Member

Changes:

Notes:

Will explore more into improving overall errors later. Have meeting with admin team regarding this topic later to understand their requirements.

@yashmurty yashmurty self-assigned this May 2, 2020
shogo-mitomo
shogo-mitomo approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@shogo-mitomo shogo-mitomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@shogo-mitomo shogo-mitomo merged commit bbd13ec into master May 3, 2020
@shogo-mitomo shogo-mitomo deleted the yash/errors branch May 3, 2020 04:43
@shogo-mitomo shogo-mitomo added enhancement New feature or request and removed 🙏 Please Review Me labels May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo-mitomo shogo-mitomo shogo-mitomo approved these changes

@DaisukeHirata DaisukeHirata Awaiting requested review from DaisukeHirata

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashmurty @shogo-mitomo