feat: add base flag to info command #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandrineP
added
the
release::enhancements
jjerphan
reviewed
Jan 31, 2025
jjerphan
reviewed
Jan 31, 2025
2 tasks
Co-authored-by: Klaim <Klaim@users.noreply.github.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Johan Mabille <johan.mabille@gmail.com> Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
…mamba-org#3792) Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
…rg#3788) Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
reviewed
Feb 12, 2025
jjerphan
added
release::bug_fixes
Hind-M
reviewed
Feb 17, 2025
Hind-M
reviewed
Feb 18, 2025
jjerphan
approved these changes
Feb 18, 2025
| else: | ||
| items += ["base environment"] | ||
| if json_flag == "--json": | ||
| assert all(i in infos.keys() for i in items) |
There was a problem hiding this comment.
Nitpick: This tests that items is a subset of infos.keys() but I guess this is sufficient
This comment also applies elsewhere.
| @@ -20,7 +20,7 @@ namespace mamba | |||
|
|
|||
| namespace detail | |||
| { | |||
| struct list_options | |||
| struct ListOptions | |||
There was a problem hiding this comment.
I agree that the current *_options structs should be PascalCase-named.
|
I am waiting for another approval before merging. |
Hind-M
reviewed
Feb 19, 2025
Hind-M
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one of the missing sub-command #3535