Skip to content

ci: Fix typo in Windows workflows #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Feb 4, 2025

Follow-up of #3769.

@jjerphan jjerphan added the release::ci_docs For PRs related to CI or documentation label Feb 4, 2025
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the fix/typo-windows-workflows branch 2 times, most recently from 1007f60 to fa956c2 Compare February 4, 2025 08:27
@jjerphan jjerphan marked this pull request as ready for review February 4, 2025 08:36
@jjerphan jjerphan merged commit d24f5d8 into mamba-org:main Feb 4, 2025
34 checks passed
@jjerphan jjerphan deleted the fix/typo-windows-workflows branch February 4, 2025 09:37
@@ -153,6 +151,4 @@ jobs:
$env:MAMBA_TEST_SHELL_TYPE='powershell'
Remove-Item -Path "env:CONDARC"
# Only rerun flaky tests on the `main` branch
python -m pytest micromamba/tests/ \
${{ runner.debug == 'true' && '-v --capture=tee-sys' || '--exitfirst' }} \
Copy link
Member

@Hind-M Hind-M Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the lines are quite long, we may think of using ` in windows as an equivalent to \ on linux.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

I initially tried but I had an error as if --exitfirst was provided on a new line.

SandrineP pushed a commit to SandrineP/mamba that referenced this pull request Feb 6, 2025
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@Hind-M Hind-M added release::maintenance For PRs realted to maintenance release::ci_docs For PRs related to CI or documentation and removed release::ci_docs For PRs related to CI or documentation release::maintenance For PRs realted to maintenance labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants