Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support fmt 11 #3368

Merged
merged 2 commits into from
Jul 29, 2024
Merged

build: Support fmt 11 #3368

merged 2 commits into from
Jul 29, 2024

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jul 29, 2024

Required changes for fmt 11:

  • fmt::join is now declared and defined in fmt/ranges.h (see fmtlib/fmt@50565f9)
  • fmt::format has to respect its argument's const-qualification

Other changes are required as include paths might have change slightly.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan marked this pull request as ready for review July 29, 2024 12:39
@Hind-M Hind-M added the release::enhancements For enhancements PRs or implementing features label Jul 29, 2024
Copy link
Member

@Hind-M Hind-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@Hind-M Hind-M merged commit 4fbd22a into mamba-org:main Jul 29, 2024
32 of 33 checks passed
@jjerphan
Copy link
Member Author

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::enhancements For enhancements PRs or implementing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants