-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin cryptography, python, and add make to environment-dev.yml #3352
Conversation
dev/environment-dev.yml
Outdated
@@ -24,7 +25,7 @@ dependencies: | |||
# micromamba dependencies | |||
- cli11 >=2.2 | |||
# micromamba test dependencies | |||
- python =3.9 # Some not too recent version | |||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't know the reason of pinning python here... Maybe this is hiding some incompatibilities. Let's see what happens with the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think unpinning python makes it get fmt 11
everywhere while #3368 only handles a part of it in the codebase.
I suggest restoring python pinning for this PR and handle fmt 11
in another one (I will open an issue for it).
Is it something blocking at the moment or more like an enhancement opening for more possibilities?
That being said, that's only showing one issue of possible other ones when unpinning python, so that would be something to check within the fixing PR.
The failures seem to be related to using |
A few other elements were required, as observed in: mamba-org#3352 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Missing elements for the support of fmt 11 are introduced in #3371. |
* build: Support fmt 11 A few other elements were required, as observed in: #3352 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> * Unpin python on 3.9 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> * ci: use libcxx<18 for macOS Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> * Add TODO comment Co-authored-by: Hind-M <Hind-M@users.noreply.github.com> Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> --------- Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Now that #3371 is merged, rebasing should hopefully fix the failures this time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm using this in some Docker containers as part of my devcontainer config, and they don't include
make
. Also, cryptography<40 is not needed anymore (see conda/conda-content-trust#57).I also unpinned
python
so you can use it on any solvable Python environment without overriding to 3.9.mitmproxy
anddoctest
are not available on linux-aarch64, so that fails, but the selector syntax only allows OS-level names, not architectures, so I can't omit those.