Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-18944: ZendClient breaks when receiving an HTTP/2 response #23

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

viktym
Copy link

@viktym viktym commented Aug 12, 2019

The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.

@magento-cicd2
Copy link

magento-cicd2 commented Aug 12, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@dyushkin dyushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review passed.

@viktym viktym merged commit 5d93556 into magento:master Aug 13, 2019
rjocoleman added a commit to rjocoleman/magento-lts that referenced this pull request Dec 4, 2019
Ref magento/zf1#23

```
The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.
```
Flyingmana pushed a commit to OpenMage/magento-lts that referenced this pull request Dec 9, 2019
Ref magento/zf1#23

```
The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.
```
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
Ref magento/zf1#23

The issue is caused by the fact that the response result is checked
by a regular expression that expects the Protocol version in the
d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns
a value in the format "HTTP/2 200 OK" without the decimal part.
randallelliott714 added a commit to randallelliott714/magento that referenced this pull request Oct 18, 2022
Ref magento/zf1#23

```
The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants