Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZendClient breaks when receiving a HTTP/2 response #867

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

rjocoleman
Copy link
Contributor

@rjocoleman rjocoleman commented Dec 4, 2019

Ref magento/zf1#23

The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.

A typical error for this would be surfaced in the UI as An error occurred while saving this configuration: Invalid header line detected (e.g. if a HTTP request was made when saving config in adminhtml)

I believe this would also solve #589

This users solution was to force the request to be HTTP 1.1 so the server would respond with a HTTP 1.1 response. The patch in this PR should handle HTTP/2 thereby solving that use-case too (from my read of the issue, I may be wrong!)

Ref magento/zf1#23

```
The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.
```
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, and was merged on their side also.

@Flyingmana Flyingmana merged commit 1e65616 into OpenMage:1.9.4.x Dec 9, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
Ref magento/zf1#23

The issue is caused by the fact that the response result is checked
by a regular expression that expects the Protocol version in the
d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns
a value in the format "HTTP/2 200 OK" without the decimal part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants