-
Notifications
You must be signed in to change notification settings - Fork 3
[MFTF] MQE-1382: "waitForPwaElement" Sample Tests #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding the support Sections, Page and Data for the new Venia Tests.
- Adding the "Thank You" section.
- Updating selectors to make them more stable. - Adding new Tests for the Storefront, Category, Product and Shopping Cart pages.
- Adding new Action Group for "GoToVeniaMobileStorefront". - Updating Tests to use the new Action Group.
- Rename branch to match the correct Story #. - Adding new Action Groups. - Replacing inline actions with Action Groups.
- Updating Test Groups to make them more specific.
- Updating stepKeys name for Action Groups.
- Adding new Category/Product/Shopping Cart Action Groups. - Updating the selectors used in the 'waitForElementVisible' action to make the AG more stable. - Updating Customer Address data. - Adding new selectors. - Adding testCaseId to the Tests. - Replacing inline actions with Action Groups.
- Replacing inline Actions with Action Groups.
- Updating the functional.suite.yml file to use the "MagentoPwaWebDriver" instead of "MagentoWebDriver".
- Renaming file to make it more specific to the Site it represents.
- Updating README to include the new Groups that I added for the Venia PWA Tests.
- Updating 'codeception.yml' file to reference the correct WebDriver, "MagentoPwaWebDriver".
- Adding sections for the Venia Header and Venia Main Menu. - Adding new selectors to the Shopping Cart section. - Adding additional Tests for the Main Menu and Shopping Cart. - Updating README to include the latest group that was added.
- Correcting "default" attribute for the Action Groups. - Correcting Action Groups by adding new "waitForPwaElementVisible" actions. - Updating selectors for the Shopping Cart so they don't try and click on the surrounding element.
Contributor
Author
|
Selector updates pushed! |
- I noticed some slowness on the Sample PWA site so I'm increasing the wait times to 30 seconds.
okolesnyk
approved these changes
Jan 28, 2019
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Add test for sort feature * Add sort pagination steps * update test Id's for next release * update description * update * update changes of pr2680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PLEASE NOTE
developbranch of MFTF (magento/magento2-functional-testing-framework: develop) or my working branch that the PR was based off of: