MQE-1382: New PWA Actions #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding a new action for waitForReactPageLoad to the schema. - Adding basic structure for the new action to the MagentoWebDriver.
- Switched gears with this attempt, created a waitForElementVisible action instead of a waitForReactPageLoad action. - Adding new action, DI updates and Actions updates.
- Renaming the new Actions to make it clear what they are for. Replaced "Js" with "Pwa".
|
|
Contributor
Author
1 similar comment
okolesnyk
requested changes
Jan 9, 2019
- Updating the action name in the Generator file.
okolesnyk
reviewed
Jan 9, 2019
src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
Outdated
Show resolved
Hide resolved
- Created a separate Class for the custom PWA actions. - Removed the custom PWA actions from MagentoWebDriver.
okolesnyk
approved these changes
Jan 14, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 22, 2023
Release 4.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains 2 new Actions for the PWA project that is under development. These new actions replicate the original Codeception
waitForElementNotVisible/waitForElementVisibleactions except JavaScript instead of PHP.waitForPwaElementNotVisiblewaitForPwaElementVisibleContribution checklist