#36423: Fixed Uncaught SyntaxError: Unexpected token '}'

[andrewbess]

Description (*)

This pull request (PR) provides fixes to resolve the problem described in the #36423

Fixed Issues (if relevant)

1. Fixes Adminhtml - Product with custom option date [required] when creating an order via admin #36423

Manual testing scenarios (*)

Please use steps to reproduce from affected issue

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrewbess. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[korovitskyi]

Hi, @andrewbess
Thank you for your work here.

Please remove underscore for the follow variables $_option and $_optionId.
Thank you.

[andrewbess]

@magento run all tests

[andrewbess]

Hello @korovitskyi
Thank you for your review and suggestions.
It has been fixed.

Please review it again.

Thank you in advance.

[andrewbess]

@magento run Static Tests, Functional Tests CE

[andrewbess]

@magento run Functional Tests CE, Functional Tests EE

[andrewbess]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[andrewbess]

It looks like flaky failures

1. Functional Tests EE

• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38401/dc9f28843d6f4bbda8f53efbc468a47d/Functional/allure-report-ee/index.html
• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38401/a0f473ada1c7da654a402d358aad1d3a/Functional/allure-report-ee/index.html
• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38401/1c73e739bd52c3db140781e8a0e2e4d9/Functional/allure-report-ee/index.html

2. Functional Tests B2B

• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38401/bceb7104317b22d741c6559a4e7281cb/Functional/allure-report-b2b/index.html
• https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38401/243647ad20519e6333be23c0e17ca884/Functional/allure-report-b2b/index.html

[andrewbess]

@magento run Functional Tests EE, Functional Tests B2B

[andrewbess]

@magento run Functional Tests EE, Functional Tests B2B

[korovitskyi]

Changes looks good for me.
@andrewbess, thank you for yout work here!

[engcom-Delta]

Hi @andrewbess , @korovitskyi

Thanks for the collaboration & contribution!

### :x: QA not Passed

What is the issue

Manual Scenario Steps

Precondition:

Magento Version 2.4-develop
PHP 8.3
Magento installed with custom date module

Steps To reproduce:

1.Set Date as drop down in Stores > Configuration > Catalog > [Date & Time Custom Options]
2.set the Date Fields Order - Day / Month / Year
3.save and clear cache
4.go to Catalog > Products > Select or add a new product
5.Add a date custom option to a product with date.phtml as required
6.go to Sales > Order
7.Create a new order, with new customer
8.Select add products
9.Select the product with the required custom option date

✔️ Expected result After Fix 

We should n't be getting any error and should be able proceed further with the product

❌ Actual result After Fix 

-> One more point I want to add that even if we are getting error in the console, we are able to proceed further to add the product and submit the order before the PR changes, after the PR changes we are getting different error but we are able to proceed further as earlier.

[engcom-Delta]

We are getting the below error

Uncaught TypeError: $(...).filter(...).collapse is not a function
at HTMLDivElement. (theme.js:629:12)
at Function.each (VM31570 jquery.js:383:35)
at theme.js:626:7
at Object.execCb (require.js:1696:33)
at Module.check (require.js:883:51)
at Module. (require.js:1139:34)
at require.js:134:23
at require.js:1189:21
at each (require.js:59:31)
at Module.emit (require.js:1188:17)

[engcom-Dash]

Hello @andrewbess,

Thanks for your contributions!

Please resolve the conflict so we can proceed with this PR.

Thanks!

[engcom-Dash]

Closing this PR since it has not been updated in a while. Please feel free to reopen if needed.