Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment improved. #27

Closed
wants to merge 1 commit into from
Closed

Comment improved. #27

wants to merge 1 commit into from

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Jun 10, 2012

No description provided.

@magento-team
Copy link
Contributor

Thank you for the proposal. However, we are not able to accept it:
a) Every pull request, as the one above, involves too large overhead of work comparing to the value it brings to the system.
b) The message is too specific, shows internals of class and in requires fixing it in many cases of changes to this method or property.
c) The message says nothing about same specific things - _store, _isSingleStore, etc. - thus it is still incomplete.

Closing.

magento-team pushed a commit that referenced this pull request Jan 16, 2015
This was referenced Mar 4, 2015
@stevieyu stevieyu mentioned this pull request Apr 3, 2015
@nabeelfocus nabeelfocus mentioned this pull request Jan 3, 2024
5 tasks
@FabXav FabXav mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants