Skip to content

Fixed - Need margin bottom to new Widget in Checkout/Cart Summary box #25745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

niravkrish
Copy link
Contributor

Description (*)

Added margin-bottom for static cms block widget after cart totals in luma and blank theme.

Fixed Issues (if relevant)

  1. Need margin bottom to new Widget in Checkout/Cart Summary box #25703: Need margin bottom to new Widget in Checkout/Cart Summary box

Manual testing scenarios (*)

  1. Manual Testing

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@fabriciosobral
Copy link

@niravkrish
Copy link
Contributor Author

Hi, @fabriciosobral,

Duplicated by https://github.com/magento/magento2/pull/25729

Please check your code first and then add this type of statement.
my code is completely different than your pull request.

Thank You,
Nirav Patel

@fabriciosobral
Copy link

I did, tks!

@krzksz
Copy link
Contributor

krzksz commented Nov 28, 2019

Hey @niravkrish, thank you for your contribution both within this and #25729. I'm going to close your PR this time and I asked Fabricio to follow the whole issue lifetime process to avoid such situations in the future.

@krzksz krzksz closed this Nov 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants