Skip to content

Need margin bottom to new Widget in Checkout/Cart Summary box #25729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2019
Merged

Need margin bottom to new Widget in Checkout/Cart Summary box #25729

merged 4 commits into from
Dec 3, 2019

Conversation

fabriciosobral
Copy link

@fabriciosobral fabriciosobral commented Nov 25, 2019 •
edited
Loading

Description (*)
Added margin-bottom for static cms block widget after cart totals in luma and blank theme.

Fixed Issues (if relevant)
#25703 Need margin bottom to new Widget in Checkout/Cart Summary box

Steps to reproduce
Create one new BLOCK with text into this
1

Create one new WIDGET
2

Attributed the block in Widget Options
3

Then make login

Add product in your Cart

Go to your cart and then "VIEW AND EDIT CART"
6

Expected result (*)
The text need margin bottom like this
result

Actual result (*)
The text dosen´t have margin bottom between the button PROCEED TO CHECKOUT

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2019

Hi @fabriciosobral. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.3 partners-contribution Pull Request is created by Magento Partner labels Nov 25, 2019
@fabriciosobral fabriciosobral changed the title Need margin bottom to new Widget in Checkout/Cart Summary box #25703 Need margin bottom to new Widget in Checkout/Cart Summary box Nov 25, 2019
@fabriciosobral fabriciosobral self-assigned this Nov 25, 2019
@ghost ghost unassigned fabriciosobral Nov 25, 2019
@ghost
Copy link

ghost commented Nov 25, 2019

@fabriciosobral unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

krzksz
krzksz suggested changes Nov 25, 2019
View reviewed changes
@ghost ghost assigned krzksz Nov 25, 2019
@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6336 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Nov 26, 2019
@niravkrish
Copy link
Contributor

niravkrish commented Nov 26, 2019 •
edited
Loading

Hello @krzksz,

The changes provided in this pull request will surely affect the whole element has a class block.

  • I have added another solution which is added the margin-bottom for the specified widget cms blocks as per the requirements.

Please compare this pr with the below pull request.
#25745

Thank You,
Nirav Patel

@krzksz
Copy link
Contributor

krzksz commented Nov 26, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25729.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@diegocpires
Copy link
Contributor

I have a doubt!

It's normal an contributor open the issue, create PR and another contributor create other PR for the same issue? Only for earn points?

@magento-engcom-team
Copy link
Contributor

Hi @fabriciosobral. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @fabriciosobral, here is your new Magento instance.
Admin access: https://pr-25729.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krzksz
Copy link
Contributor

krzksz commented Nov 28, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25729.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krzksz
Copy link
Contributor

krzksz commented Nov 28, 2019

Looks good now:
obraz

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6336 has been created to process this Pull Request

@krzksz krzksz mentioned this pull request Nov 28, 2019
Closed
4 tasks
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

Note: The same results and on the Blank theme

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 28, 2019
@ghost ghost assigned rodrigowebjump Nov 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6336 has been created to process this Pull Request

@VladimirZaets VladimirZaets mentioned this pull request Dec 3, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Dec 3, 2019
@VladimirZaets
ENGCOM-6336: Need margin bottom to new Widget in Checkout/Cart Summar…
b0ec4ef 
…y box #25729
@magento-engcom-team magento-engcom-team merged commit c4a3e51 into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @fabriciosobral, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegocpires diegocpires diegocpires left review comments

@LucasCalazans LucasCalazans LucasCalazans left review comments

@niravkrish niravkrish niravkrish left review comments

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

@krzksz krzksz krzksz approved these changes

Assignees

@rodrigowebjump rodrigowebjump

@krzksz krzksz

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Webjump partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
9 participants
@fabriciosobral @magento-engcom-team @niravkrish @krzksz @diegocpires @engcom-Alfa @rodrigowebjump @LucasCalazans @engcom-Foxtrot