Skip to content

Fixed Magento is no refreshing the cart page if you delete a product from cart side block #22478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 3, 2019
Merged

Fixed Magento is no refreshing the cart page if you delete a product from cart side block #22478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60a465c
Fixed Magento is no refreshing the cart page if you delete a product …
ravi-chandra3197 Apr 24, 2019
c08dffb
Fixed Magento is no refreshing the cart page if you delete a product …
ravi-chandra3197 Apr 24, 2019
7d481bd
Fixed Magento is no refreshing the cart page if you delete a product …
ravi-chandra3197 Apr 25, 2019
ce6c228
Fixed Magento is no refreshing the cart page if you delete a product …
ravi-chandra3197 Apr 25, 2019
b370b1e
magento/magento2#22478: Move reload logic to the appropriate place
sidolov Aug 16, 2019
bcd75f4
Update sidebar.js
sidolov Aug 23, 2019
73b9612
Update sidebar.js
sidolov Aug 27, 2019
49936ba
magento/magento2#22478: Static test fix.
engcom-Foxtrot Aug 29, 2019
aa7ac82
magento/magento2#22478: MFTF test fix.
engcom-Foxtrot Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...Magento/Checkout/Test/Mftf/Test/NoErrorCartCheckoutForProductsDeletedFromMiniCartTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
<see selector="{{StoreFrontRemoveItemModalSection.message}}" userInput="Are you sure you would like to remove this item from the shopping cart?" stepKey="seeDeleteConfirmationMessage"/>
<click selector="{{StoreFrontRemoveItemModalSection.ok}}" stepKey="confirmDelete"/>
<waitForPageLoad stepKey="waitForDeleteToFinish"/>
<click selector="{{CheckoutCartProductSection.RemoveItem}}" stepKey="deleteProductFromCheckoutCart"/>
<dontSeeElement selector="{{CheckoutCartProductSection.RemoveItem}}" stepKey="dontSeeDeleteProductFromCheckoutCart"/>
<click selector="{{StorefrontMinicartSection.showCart}}" stepKey="clickCart"/>
<waitForPageLoad stepKey="WaitForPageLoad3"/>
<see userInput="You have no items in your shopping cart." stepKey="seeNoItemsInShoppingCart"/>
</test>
Expand Down
4 changes: 4 additions & 0 deletions app/code/Magento/Checkout/view/frontend/web/js/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ define([
$(document).trigger('ajax:removeFromCart', {
productIds: [productData['product_id']]
});

if (window.location.href.indexOf(this.shoppingCartUrl) === 0) {
window.location.reload();
}
}
},

Expand Down