Fixed Magento is no refreshing the cart page if you delete a product from cart side block #22478

ravi-chandra3197 · 2019-04-24T10:16:13Z

Description (*)

Fixed Magento is no refreshing the cart page if you delete a product from cart side block

Fixed Issues (if relevant)

Magento is no refreshing the cart page if you delete a product from cart side block #11292: Magento is no refreshing the cart page if you delete a product from cart side block

Manual testing scenarios (*)

Add a product to cart
Go to cart page
Delete the product from cart side block

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…from cart side block

m2-assistant · 2019-04-24T10:16:16Z

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

…from cart side block(update var name)

orlangur · 2019-04-24T11:33:00Z

app/code/Magento/Checkout/view/frontend/web/js/sidebar.js

@@ -310,6 +310,10 @@ define([

                    if (response.success) {
                        callback.call(this, elem, response);
+                        var currentURL = window.location.pathname;
+                        if (currentURL.includes("/checkout/cart/")) {
+                            location.reload();


Nope, such behavior is unacceptable. Please read comments in corresponding issue more carefully.

Needed page content must be re-rendered via AJAX.

Hello @orlangur
As per Expected result issue, we need to reload the page because only mini cart load data using ajax,
but for update same change in checkout/cart/index page, we need reload page

@ravi-chandra3197 no.

@ravi-chandra3197 expected result is now fixed to avoid confusion

Hello @orlangur
For update mini cart change in cart page, we need to reload checkout/cart/index because it's not a problem to just update product but also subtotal, Discount Code and additional info like shipping charges, so we need to reload cart page instead of re-rendered cart page small part

@ravi-chandra3197 full page reload is not acceptable. Reload only what is needed to be reloaded.

…from cart side block(reload only cart block)

…from cart side block(reload page on delete)

orlangur · 2019-04-26T22:25:37Z

app/code/Magento/Checkout/view/frontend/web/js/sidebar.js

@@ -310,6 +310,10 @@ define([

                    if (response.success) {
                        callback.call(this, elem, response);
+                        var currentURL = window.location.pathname;
+                        if (currentURL.includes("/checkout/cart/")) {
+                            location.reload();


@ravi-chandra3197 full page reload is not acceptable. Reload only what is needed to be reloaded.

ihor-sviziev · 2019-05-16T14:17:12Z

Hi @orlangur,
Currently in case when you'll update product qty from mini cart - it just refreshing the page.
Why do we need to invent new functionality for products deleting?

sidolov · 2019-08-16T19:59:25Z

Agree with @ihor-sviziev , just moved reload logic to the appropriate place

magento-engcom-team · 2019-08-16T19:59:47Z

Hi @sidolov, thank you for the review.
ENGCOM-5649 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2019-08-21T08:53:19Z

Hi @ravi-chandra3197

I've checked PR on branch with changes and looks like the issue is not resolved

Manual testing scenario:

Add a product to cart;
Go to Cart page;
Delete product from mini-cart popup;

Actual Result:
❌ Cart page still shows the product in the cart

@ravi-chandra3197 Could you take a look?

Thanks!

ihor-sviziev · 2019-08-21T13:53:07Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-08-21T13:53:08Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

sidolov · 2019-08-23T17:08:58Z

@ihor-sviziev ah, yes, we should use indexOf

engcom-Alfa · 2019-08-27T13:35:08Z

Hi @sidolov

I've checked this PR and looks like changes don't solve the problem.
But with the changes suggested by @ihor-sviziev in #comment all works correctly.

@sidolov Could you take a look, please?

Thanks!

sidolov · 2019-08-27T14:54:05Z

@engcom-Alfa , changes are applied, please, check again

magento-engcom-team · 2019-08-27T14:54:57Z

Hi @sidolov, thank you for the review.
ENGCOM-5649 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2019-08-28T07:20:51Z

✔️ QA Passed

Actual Result:

engcom-Foxtrot · 2019-08-29T15:35:44Z

@magento run all tests

…te a product from cart side block #22478

m2-assistant · 2019-09-03T18:21:50Z

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed Magento is no refreshing the cart page if you delete a product …

60a465c

…from cart side block

magento-engcom-team added Area: Frontend Component: Checkout Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Apr 24, 2019

Fixed Magento is no refreshing the cart page if you delete a product …

c08dffb

…from cart side block(update var name)

orlangur requested changes Apr 24, 2019

View reviewed changes

ghost assigned orlangur Apr 24, 2019

ghost added the Progress: needs update label Apr 24, 2019

ravi-chandra3197 added 2 commits April 25, 2019 11:54

Fixed Magento is no refreshing the cart page if you delete a product …

7d481bd

…from cart side block(reload only cart block)

Fixed Magento is no refreshing the cart page if you delete a product …

ce6c228

…from cart side block(reload page on delete)

orlangur requested changes Apr 26, 2019

View reviewed changes

magento#22478: Move reload logic to the appropriate place

b370b1e

sidolov approved these changes Aug 16, 2019

View reviewed changes

ghost assigned sidolov Aug 16, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 16, 2019

engcom-Alfa self-assigned this Aug 21, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 21, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 21, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 27, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 27, 2019

Update sidebar.js

73b9612

sidolov approved these changes Aug 27, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 27, 2019

ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 27, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 28, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 28, 2019

engcom-Foxtrot self-assigned this Aug 28, 2019

magento#22478: Static test fix.

49936ba

magento#22478: MFTF test fix.

aa7ac82

ghost added Progress: accept and removed Progress: extended testing labels Sep 3, 2019

magento-engcom-team mentioned this pull request Sep 3, 2019

Magento is no refreshing the cart page if you delete a product from cart side block #11292

Closed

magento-engcom-team pushed a commit that referenced this pull request Sep 3, 2019

ENGCOM-5649: Fixed Magento is no refreshing the cart page if you dele…

a14c101

…te a product from cart side block #22478

magento-engcom-team merged commit aa7ac82 into magento:2.3-develop Sep 3, 2019

magento-engcom-team added this to the Release: 2.3.4 milestone Sep 3, 2019

addison74 mentioned this pull request Jun 7, 2022

OM is not reloading the cart page if deleting a product from cart side block OpenMage/magento-lts#2204

Closed

Fixed Magento is no refreshing the cart page if you delete a product from cart side block #22478

Fixed Magento is no refreshing the cart page if you delete a product from cart side block #22478

Uh oh!

Conversation

ravi-chandra3197 commented Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Apr 24, 2019

Uh oh!

orlangur Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

ravi-chandra3197 Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

orlangur Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

orlangur Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

ravi-chandra3197 Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

orlangur Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

orlangur Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidolov commented Aug 16, 2019

Uh oh!

magento-engcom-team commented Aug 16, 2019

Uh oh!

engcom-Alfa commented Aug 21, 2019

Uh oh!

ihor-sviziev commented Aug 21, 2019

Uh oh!

magento-engcom-team commented Aug 21, 2019

Uh oh!

sidolov commented Aug 23, 2019

Uh oh!

engcom-Alfa commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidolov commented Aug 27, 2019

Uh oh!

magento-engcom-team commented Aug 27, 2019

Uh oh!

engcom-Alfa commented Aug 28, 2019

Uh oh!

engcom-Foxtrot commented Aug 29, 2019

Uh oh!

m2-assistant bot commented Sep 3, 2019

Uh oh!

Uh oh!

ravi-chandra3197 commented Apr 24, 2019 •

edited

Loading

ihor-sviziev commented May 16, 2019 •

edited

Loading

engcom-Alfa commented Aug 27, 2019 •

edited

Loading