Wrong currency sign on creditmemo_grid & sales_order_view > invoice grid

[latenights]

Description (*)

Added missing column base_currency_code & order_currency_code to table sales_creditmemo_grid. Price column rendering changed on sales_creditmemo_index (Creditmemo grid) & sales_order_view - Invoice tab.

Fixed Issues

1. Wrong currency sign on creditmemo_grid & sales_order_view > invoice grid #22490

Manual testing scenarios (*)

1. Create order in different currency as configured on default store view
2. Go to Backend > SALES > Credit Memos, create Credit Memo
3. Check Refunded & Subtotal column on Credit Memo grid (sales_creditmemo_index). You should see price in currency configured on default store view (base_currency_code).
4. Go to Backend > SALES > Orders > choose your order and check Invoice grid in Invoices tab. Amount should be base grand total with base_currency_code.

sales_order_view > Credit Memos (base grand total):

sales_order_view > Invoices (grand total):

sales_creditmemo_index (wrong currency sign):

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @latenights. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Hey @latenights, could you please

I mean please report an issue and just link it in both PRs so that this bug and its fix may be properly tracked.

[latenights]

@orlangur Issue #22490 created.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5194 has been created to process this Pull Request

[magento-engcom-team]

@latenights thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[soleksii]

✔️ QA Passed

Before:

After:

[magento-engcom-team]

@latenights thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@latenights thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@latenights thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@latenights thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[m2-assistant]

Hi @latenights, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ghost]

@latenights unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request