Skip to content

[Backport] Wrong currency on creditmemo_grid & sales_order_view > creditmemo grid #22114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

latenights
Copy link
Member

@latenights latenights commented Apr 2, 2019

Description (*)

Added missing column order_currency_code to table sales_creditmemo_grid. Copying column order_currency_code to sales_creditmemo_grid. Price column rendering changed on sales_creditmemo_index (Creditmemo grid) & sales_order_view - Creditmemo tab.

Manual testing scenarios (*)

  1. Create order in different currency as configured on default store view
  2. Go to Backend > SALES > Credit Memos, create Credit Memo
  3. Check Refunded column on Credit Memo grid. You should see price in currency configured on default store view.
  4. Go to Backend > SALES > Orders > choose your order and check Credit Memo grid in Credit Memos tab. You should see price in currency configured on default store view.

sales_order_view:
image

sales_creditmemo_index:
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #22123

@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2019

Hi @latenights. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 2, 2019

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Apr 2, 2019
@orlangur
Copy link
Contributor

orlangur commented Apr 2, 2019

@latenights please report a bug report separately and fix in 2.3-develop first if it is reproducible.

@latenights
Copy link
Member Author

@orlangur In M2.3 is also messed up. Different currencies (base currency code & order currency code). M2.3 Pull request created #22123

@orlangur
Copy link
Contributor

orlangur commented Apr 5, 2019

@latenights surely. I mean please report an issue and just link it in both PRs so that this bug and its fix may be properly tracked.

@sidolov sidolov changed the title Wrong currency on creditmemo_grid & sales_order_view > creditmemo grid [Backport] Wrong currency on creditmemo_grid & sales_order_view > creditmemo grid Apr 24, 2019
@VladimirZaets
Copy link
Contributor

Hi @latenights. The branch 2.2-develop will be closed for contribution from July 15, 2019. Please finish all your Pull Requests till this date, otherwise, they will be closed.
Thanks for collaboration.

@orlangur
Copy link
Contributor

Closing as 2.3 PR is still not merged.

@orlangur orlangur closed this Jul 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @latenights, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants