Really hide Pdf totals with zero amounts #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The false value used here https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/etc/pdf.xml#L33 gets represented as a string which leads to all totals being shown in the pdfs even if the amount is 0 and it is configured to not show. Checking for the string true fixes it.
vpelipenko
added
CS
Issue: Ready for Work
|
Internal ticket: MAGETWO-40653 |
magento-team
pushed a commit
that referenced
this pull request
Sep 29, 2017
[EngCom] Public Pull Requests2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The false value used here https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/etc/pdf.xml#L33 gets represented as a string which leads to all totals being shown in the pdfs even if the amount is 0 and it is configured to not show. Checking for the string true fixes it.