Skip to content

Commit

Permalink
string false does not evaluate to false
Browse files Browse the repository at this point in the history
The false value used here https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/etc/pdf.xml#L33 gets represented as a string which leads to all totals being shown in the pdfs even if the amount is 0 and it is configured to not show. Checking for the string true fixes it.
  • Loading branch information
fooman committed Jul 21, 2015
1 parent 043b721 commit 42f53f8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function getFullTaxInfo()
public function canDisplay()
{
$amount = $this->getAmount();
return $this->getDisplayZero() || $amount != 0;
return $this->getDisplayZero() === 'true' || $amount != 0;
}

/**
Expand Down

0 comments on commit 42f53f8

Please sign in to comment.