Skip to content

CSS load order incorrect using default_head_blocks.xml #1821 #14290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2018
Merged

CSS load order incorrect using default_head_blocks.xml #1821 #14290

merged 1 commit into from
Apr 20, 2018

Conversation

SerhiyDmytruk
Copy link
Contributor

Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.

Fixed Issues (if relevant)

  1. CSS load order incorrect using default_head_blocks.xml #1821: CSS load order incorrect using default_head_blocks.xml CSS load order incorrect using default_head_blocks.xml #1821

Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 23, 2018

CLA assistant check
All committers have signed the CLA.

@SerhiyDmytruk SerhiyDmytruk changed the title Fix bug #1821 CSS load order incorrect using default_head_blocks.xml #1821 Mar 23, 2018
@larsroettig
Copy link
Member

larsroettig commented Mar 24, 2018

Hi @SergeyDmitruk,
you PR have currently failed static test pls take look and fix this.

Thank you best regards,
Lars

@magento-engcom-team
Copy link
Contributor

Hi @SergeyDmitruk. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

ihor-sviziev pushed a commit to ihor-sviziev/magento2 that referenced this pull request Apr 23, 2018
ihor-sviziev pushed a commit to ihor-sviziev/magento2 that referenced this pull request Apr 23, 2018
ihor-sviziev pushed a commit to ihor-sviziev/magento2 that referenced this pull request Apr 23, 2018
@ihor-sviziev
Copy link
Contributor

Hi @SergeyDmitruk,

I tried to create forwardport PR to 2.3-develop branch, but unfortunately it brakes swagger functionality, more details here: #14815 (comment)

Could you prepare forwardport PR with all needed changes to 2.3-develop branch, because it seems you know this context much better then me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants