Skip to content

[Forwardport] CSS load order incorrect using default_head_blocks.xml #1821 #14815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Forwardport] CSS load order incorrect using default_head_blocks.xml #1821 #14815

wants to merge 4 commits into from

Conversation

ihor-sviziev
Copy link
Contributor

Original Pull Request

#14290
Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.

Fixed Issues (if relevant)

  1. CSS load order incorrect using default_head_blocks.xml #1821: CSS load order incorrect using default_head_blocks.xml CSS load order incorrect using default_head_blocks.xml #1821

@SerhiyDmytruk @ihor-sviziev
Fix bug magento#1821
b9f68bf 
Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 23, 2018
@VladimirZaets
Copy link
Contributor

VladimirZaets commented Apr 23, 2018 •
edited
Loading

Hi, @ihor-sviziev , thank you for collaboration. But, unfortunately, this isn't the full fix. Please look at commits 21cb3af6210c248097e9d6b27a473a1456973b16 , 51c78b9414a3e23bc8d31cd571b98b95d0c949b9 and ad82a7aadafcc67e451a090afed6d5258512101d in current 2.2-develop branch.

@ishakhsuvarov
Copy link
Contributor

@magento-engcom-team give me new test instance

@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov. Thank you for your request. I'm working on Magento instance for you

@ishakhsuvarov ishakhsuvarov self-assigned this May 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov, here is your new Magento instance.
Admin access: https://pr-14815.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@ishakhsuvarov
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov, here is your Magento instance.
Admin access: https://i-14815-2-3-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VladimirZaets
Copy link
Contributor

Hi @ihor-sviziev , currently this fix breaks down the swagger functionality. The problem is in swagger implementation. Swagger does not have dependencies. Because your fix changes the loading order, the Swagger is loading before than libraries that he uses.
The Swagger was fixed and updated in Magento 2.2 version, so will be great if you make forward port to Magento 2.3

@ihor-sviziev ihor-sviziev mentioned this pull request May 4, 2018
Merged
@ihor-sviziev
Copy link
Contributor Author

Hi @VladimirZaets,
I don't have free time to fix these issues. I'm closing my PR.
Feel free to create new forwardport PR if you have time for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

@VladimirZaets VladimirZaets

Labels
Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@ihor-sviziev @VladimirZaets @ishakhsuvarov @magento-engcom-team @SerhiyDmytruk