Skip to content

Fix issues caused by using continue in loops #13073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix issues caused by using continue in loops #13073

wants to merge 1 commit into from

Conversation

ihor-sviziev
Copy link
Contributor

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev
Fix issues caused by using continue in loops
2b47c8f 
- Fix echoing "continue;" instead of executing it
- Replace continue to opposite condition in if blocks
@ihor-sviziev ihor-sviziev requested a review from orlangur January 9, 2018 12:51
@orlangur orlangur self-assigned this Jan 9, 2018
@orlangur orlangur added this to the January 2018 milestone Jan 9, 2018
@ihor-sviziev ihor-sviziev deleted the fix-issue-with-continue-in-templates branch January 9, 2018 13:15
@ihor-sviziev
Copy link
Contributor Author

New PR: #13076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur Awaiting requested review from orlangur

Assignees

@orlangur orlangur

Labels
duplicate Release Line: 2.2
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@ihor-sviziev @orlangur