FIX: remove not used count() from templates #12901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @orlangur can you please review this PR when you will have a time? :) |
orlangur
approved these changes
Jan 8, 2018
ihor-sviziev
reviewed
Jan 9, 2018
| continue; | ||
| } ?> | ||
| <?php if ($_item->getOrderItem()->getParentItem()): ?> | ||
| continue; |
There was a problem hiding this comment.
@ihor-sviziev @orlangur thank you for your review. Yep, it was an error. Thanks once more for your help!
ihor-sviziev
reviewed
Jan 9, 2018
| continue; | ||
| } ?> | ||
| <?php if ($_item->getOrderItem()->getParentItem()): ?> | ||
| continue; |
There was a problem hiding this comment.
The same issue it there.
There was a problem hiding this comment.
@ihor-sviziev Thank you so much for your review. Sorry, it was my fail :(
There was a problem hiding this comment.
@coderimus no problem. I just created new PR that fixing this issue
This was referenced Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Magento2,
The main goal of this PR is to remove not used
count($_items)in templates. Please, check Description section for details.Thank you,
Alex
Description
Found that in some templates Magento2 counts items for table rendering and other stuff but files, add to this PR, do not use
$_countvariable and<?php $_count = count($_items) ?>can be excluded from them.Fixed Issues (if relevant)
Not related issue found.
Manual testing scenarios
No need to be tested because just removing a not used variable from templates.
Contribution checklist