-
Notifications
You must be signed in to change notification settings - Fork 197
MCLOUD-6469: dh key too small when trying to use magento-cloud-docker… #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadiyaS
previously approved these changes
Aug 17, 2020
3 tasks
oshmyheliuk
reviewed
Aug 18, 2020
images/web/Dockerfile
Outdated
&& echo -e "\n\n\n\n\n\n\n" | openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout /etc/nginx/ssl/magento.key -out /etc/nginx/ssl/magento.crt | ||
#RUN apt-get update && apt-get install -y openssl curl | ||
#RUN mkdir /etc/nginx/ssl \ | ||
# && openssl req -x509 -nodes -days 365 -newkey rsa:4096 -keyout /etc/nginx/ssl/magento.key -out /etc/nginx/ssl/magento.crt -subj "/C=CH/ST=Zurich/L=Zurich/O=Snakeoil Inc/OU=IT Department/CN=magento2.docker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a good practice to have commented lines of code. Please remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
oshmyheliuk
previously approved these changes
Aug 18, 2020
oshmyheliuk
previously approved these changes
Aug 18, 2020
NadiyaS
previously approved these changes
Aug 18, 2020
39b1821
oshmyheliuk
previously approved these changes
Aug 18, 2020
QA Approved |
oshmyheliuk
previously approved these changes
Aug 18, 2020
NadiyaS
approved these changes
Aug 19, 2020
oshmyheliuk
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-tls
Description
Fixed Issues (if relevant)
Manual testing scenarios
Build images locally:
Override config:
Release notes
Upgraded software version for NGINX (1.19) and rebased TLS on Nginx.
Contribution checklist