Skip to content

MCLOUD-6469: dh key too small when trying to use magento-cloud-docker… #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2020

Conversation

shiftedreality
Copy link
Member

@shiftedreality shiftedreality commented Aug 17, 2020

…-tls

Description

Fixed Issues (if relevant)

  1. https://jira.corp.magento.com/browse/MCLOUD-6469
  2. Updated nginx image to latest
  3. dh key too small when trying to use magento-cloud-docker-tls #257
  4. MCLOUD-6428: Issue with varnish cache(http urls are not caching) - Magento2 docker setup #236

Manual testing scenarios

Build images locally:

#!/bin/bash

docker build -t test/php:7.4-fpm ../magento-cloud-docker/images/php/7.4-fpm
docker build -t test/web:latest ../magento-cloud-docker/images/web

Override config:

docker-compose.override.yml
version: '2.1'
services:
    fpm:
        image: 'test/php:7.4-fpm'
    tls:
        image: 'test/web:latest'
    web:
        image: 'test/web:latest'
  1. Test in Production mode
  2. Test in Developer mode

Release notes

Upgraded software version for NGINX (1.19) and rebased TLS on Nginx.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

NadiyaS
NadiyaS previously approved these changes Aug 17, 2020
&& echo -e "\n\n\n\n\n\n\n" | openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout /etc/nginx/ssl/magento.key -out /etc/nginx/ssl/magento.crt
#RUN apt-get update && apt-get install -y openssl curl
#RUN mkdir /etc/nginx/ssl \
# && openssl req -x509 -nodes -days 365 -newkey rsa:4096 -keyout /etc/nginx/ssl/magento.key -out /etc/nginx/ssl/magento.crt -subj "/C=CH/ST=Zurich/L=Zurich/O=Snakeoil Inc/OU=IT Department/CN=magento2.docker"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good practice to have commented lines of code. Please remove them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

oshmyheliuk
oshmyheliuk previously approved these changes Aug 18, 2020
oshmyheliuk
oshmyheliuk previously approved these changes Aug 18, 2020
NadiyaS
NadiyaS previously approved these changes Aug 18, 2020
@shiftedreality shiftedreality dismissed stale reviews from NadiyaS and oshmyheliuk via 39b1821 August 18, 2020 18:51
oshmyheliuk
oshmyheliuk previously approved these changes Aug 18, 2020
@oshmyheliuk
Copy link
Contributor

QA Approved

oshmyheliuk
oshmyheliuk previously approved these changes Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants