This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updated Cloud Docker container info and clean up markdown #8216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2020 18:18
- Added TLS docker image change from Centos to NGINX - Updated service containers table with TLS update and added missing Xdebug and MailHog containers
meker12
added
the
Internal Dev
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
meker12
added
the
Technical
hguthrie
suggested changes
Nov 12, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
Fix information about the `--tls-port` option.
hguthrie
approved these changes
Nov 12, 2020
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
- Add missing options to Docker launch topics and clean up markdown - Clean up containers topic - Indicate node container is optional, table clean up Clean up service and cli containers topics - update node container description, fix TLS container description - Update the Xdebug topic with current local configuration for MailHog container
meker12
changed the title
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
meker12
commented
Nov 13, 2020
meker12
commented
Nov 13, 2020
meker12
commented
Nov 13, 2020
hguthrie
reviewed
Nov 13, 2020
| @@ -68,12 +68,15 @@ docker-compose run --rm build magento-command setup:static-content:deploy | |||
|
|
|||
| The Cron container runs operations in the background immediately after the Docker environment starts. This container uses the cron configuration defined in the [`crons` property of the `.magento.app.yaml` file]({{ site.baseurl }}/cloud/project/magento-app-properties.html#crons). This container has no custom configuration. | |||
|
|
|||
| {:.bs-callout-info} | |||
| To improve the overall performance in the Docker development and production environments, the Cron container is not present by default. You can use the following command to add the Cron container to the Cloud Docker environment: `./vendor/bin/ece-docker build:compose --mode="developer" --with-cron` | |||
There was a problem hiding this comment.
Are they environments or modes? Wouldn't it be developer and not development?
hguthrie
reviewed
Nov 13, 2020
meker12
commented
Nov 13, 2020
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
meker12
commented
Nov 13, 2020
|
running tests |
|
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
-tls-portoption for theece-docker build:composecommandAffected DevDocs pages
Links to Magento source code
magento/magento-cloud-docker#277
whatsnew
Updated the Service containers topic in the Cloud Guide to provide current information about the TLS, MailHog, and Xdebug containers.