Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Code formatting #2457

Closed
wants to merge 21 commits into from
Closed

Code formatting #2457

wants to merge 21 commits into from

Conversation

tejash-wagento
Copy link
Contributor

This PR is a:

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Code formatting
When this pull request is merged, it will...

Additional information

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 10, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ meker12
✅ shrielenee
✅ tejash-wagento
❌ tejash


tejash seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@mhauri
Copy link

mhauri commented Jul 10, 2018

Hi @tejash-wagento thank you for your contribution.
Would you mind to merge all your changes from the other Pull Requests you opened into this one and to close all others?

#2466
#2464
#2463
#2462
#2461
#2460
#2459
#2458

@tejash-wagento
Copy link
Contributor Author

@mhauri
I have merged my all branches in patch-1.

@mhauri
Copy link

mhauri commented Jul 10, 2018

@tejash-wagento thank you, it would be great if you can squash all your commits into one was well, as it is bad practice to have multiple commits with the same message. Also close the other PR's so we can handle this one here only.

@jeff-matthews jeff-matthews added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jul 10, 2018
@mhauri mhauri mentioned this pull request Jul 10, 2018
3 tasks
@jeff-matthews
Copy link
Contributor

We also need to change the base branch to master @mhauri. You probably can't do that without write access to the repo, so I'll change it.

@jeff-matthews jeff-matthews changed the base branch from develop to master July 10, 2018 14:35
@bdenham bdenham added the Waiting for Response Waiting for response from internal/external parties label Jul 10, 2018
@@ -199,7 +199,7 @@ A long list of response headers display in your command prompt window. Look for
- VCL_call BACKEND_FETCH
- VCL_return fetch
- BackendOpen 17 default(10.249.151.10,,8080) 10.249.151.10 60914
- Backend 17 default default(10.249.151.10,,8080)
- Backend 17 default(10.249.151.10,,8080)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejash-wagento, Hi
These changes are already fixed and accepted. in this PR: #2448

@@ -199,7 +199,7 @@ A long list of response headers display in your command prompt window. Look for
- VCL_call BACKEND_FETCH
- VCL_return fetch
- BackendOpen 17 default(10.249.151.10,,8080) 10.249.151.10 60914
- Backend 17 default default(10.249.151.10,,8080)
- Backend 17 default(10.249.151.10,,8080)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejash-wagento, Hi
These changes are already fixed and accepted. in this PR: #2448

@jeff-matthews
Copy link
Contributor

@tejash-wagento,

We haven't heard from you regarding this PR in two weeks, so we're closing this PR due to inactivity. If you have further comments and feedback, please create a new PR. Thanks for taking the time to create a GitHub issue for docs improvement!

@jeff-matthews jeff-matthews removed the Waiting for Response Waiting for response from internal/external parties label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants