Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Corrected typo mistakes in pattern-library files. #2448

Merged
merged 5 commits into from
Jul 10, 2018

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Jul 9, 2018

This PR is a:

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Corrected typo mistakes in pattern-library files for version 2.x .

Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes before we're ready to merge! Please make sure that versions 2.1-2.3 will get your changes.

@@ -469,7 +469,8 @@ Some data-tables will be used to display "settings" content. In these instances
<br />
<br />
<h3>Single Select Button</h3>
The data table can also accommodate buttons in rows, and has a special case in the "Single Select" button. This button functions not unlike a typical radio button control, but is used instead of the radio button when the task flow or experience in the {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} application are better served with the more implicit action of selecting a single choice from a data table. This provides greater visibility and imediate confirmation of the action to the user. The use of this should be carefully considered in the context of the experience to determine if it provides greater understanding to the user than radio buttons.

The data table can also accommodate buttons in rows, and has a special case in the "Single Select" button. This button functions not unlike a typical radio button control, but is used instead of the radio button when the task flow or experience in the {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} application are better served with the more implicit action of selecting a single choice from a data table. This provides greater visibility and immediate confirmation of the action to the user. The use of this should be carefully considered in the context of the experience to determine if it provides greater understanding to the user than radio buttons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double spaces before new sentences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrielenee Done!

@@ -323,7 +323,7 @@ Views can be named or deleted by clicking an edit icon. Refer to "Adding a custo
## Filters {#filters}
Filters allow users to customize the display of information in an associated data-table. By entering desired parameters (for example, a date range) in the available filter input sections table returns a modified view, making visible only the records meeting the user-determined criteria.

### Advanced Filters
<h3>Advanced Filters</h3>
To access the Advanced Filters the user may click/tap the "Filters" button found in the table controls area. When activated, the button transforms into a tab and displays the available filters in a 'drawer' which opens between the table controls and the table data. The available filters are determined by the columns present in the table; therefore, if the user customizes the column visibility of the table to show some columns and hide others, the corresponding filters for these columns will display or hide in the filter 'drawer'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change. We use markdown for headings, not HTML.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

### Single Select Button
The data table can also accommodate buttons in rows, and has a special case in the "Single Select" button. This button functions not unlike a typical radio button control, but is used instead of the radio button when the task flow or experience in the {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} application are better served with the more implicit action of selecting a single choice from a data table. This provides greater visibility and imediate confirmation of the action to the user. The use of this should be carefully considered in the context of the experience to determine if it provides greater understanding to the user than radio buttons.
The data table can also accommodate buttons in rows, and has a special case in the "Single Select" button. This button functions not unlike a typical radio button control, but is used instead of the radio button when the task flow or experience in the {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} application are better served with the more implicit action of selecting a single choice from a data table. This provides greater visibility and immediate confirmation of the action to the user. The use of this should be carefully considered in the context of the experience to determine if it provides greater understanding to the user than radio buttons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double spaces before sentences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shrielenee shrielenee added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.0.x Waiting for Response Waiting for response from internal/external parties 2.x and removed 2.0.x labels Jul 9, 2018
@sanganinamrata
Copy link
Member Author

@shrielenee , I'm done with the mentioned changes.

@shrielenee
Copy link
Contributor

Great @sanganinamrata!

@shrielenee shrielenee merged commit 49f0444 into magento:master Jul 10, 2018
@sanganinamrata sanganinamrata mentioned this pull request Jul 11, 2018
3 tasks
@sanganinamrata sanganinamrata deleted the nps-grammar-corrections-1 branch July 11, 2018 05:10
@hguthrie hguthrie removed the Waiting for Response Waiting for response from internal/external parties label Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants