Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl Schema actualization with latest released changes. #419

Conversation

swnsma
Copy link

@swnsma swnsma commented Aug 8, 2020

Problem

  1. In-Store Pickup GraphQl schema is not up-to-date with released and documented schema.
  2. Products assignment intersection filter was missed from GraphQl API in the initial implementation.

Solution

  1. Update schema from the inventory repo.
  2. Introduce productsInfo parameter for assignment intersection filter.

Requested Reviewers

@joni-jones
@paliarush

Additional

GraphQl Implementation in: magento/inventory#3161
Original ticket for functionality: magento/inventory#2825
REST API implementation: magento/inventory#2867

Add ProductInfo to the schema for intesection search.
pageSize: Int = 20,
currentPage: Int = 1
currentPage: Int = 1,
productsInfo: [ProductInfoInput]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this field exist?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is going to be delivered in magento/inventory#3161

@melnikovi
Copy link
Member

Please resolve merge conflicts.

@melnikovi melnikovi self-assigned this Sep 9, 2020
@swnsma
Copy link
Author

swnsma commented Sep 10, 2020

@melnikovi resolved

@melnikovi melnikovi merged commit 2748e2b into magento:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants