Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msi 2825 hide store pickup on the checkout if one of the products in cart is not available for pickup #2867

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Mar 8, 2020

Description (*)

#2825

Fixed Issues (if relevant)

  1. Hide store pickup on the Checkout if one of the products in cart is not available for pickup #2825: Hide store pickup during order submissions if one of the products is not available for pickup

Dependencies

Depends on #2839

…cart-is-not-available-for-pickup.

Add validator with check of product assignment intersection.
swnsma and others added 5 commits March 8, 2020 22:03
…ckout-if-one-of-the-products-in-cart-is-not-available-for-pickup
…one-of-the-products-is-not-available-for-pickup' into MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup
…e-products-in-cart-is-not-available-for-pickup' of github.com:magento/inventory into MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup
…one-of-the-products-is-not-available-for-pickup' into MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup
…cart-is-not-available-for-pickup.

Fix typo in namespace.
novikor added a commit that referenced this pull request Mar 9, 2020
…cart is not available for pickup #2867.

Fixed static tests
@novikor novikor changed the base branch from 1.2-develop to MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup March 9, 2020 19:24
…cart is not available for pickup #2867.

Fixed static tests
@novikor novikor force-pushed the MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup branch from 5e406be to 7e0212e Compare March 9, 2020 19:25
oleksandrkravchuk added 2 commits March 9, 2020 20:39
…cart-is-not-available-for-pickup.

Fix tests.
…e-products-in-cart-is-not-available-for-pickup' of github.com:magento/inventory into MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup
@swnsma swnsma marked this pull request as ready for review March 9, 2020 19:45
novikor
novikor previously approved these changes Mar 10, 2020
@novikor novikor added Auto-Tests: Covered All changes in Pull Request are covered by auto-tests Award: test coverage and removed Progress: approved labels Mar 10, 2020
@sidolov sidolov dismissed novikor’s stale review March 12, 2020 20:05

The base branch was changed.

@sidolov sidolov changed the base branch from MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup to 1.2-develop March 12, 2020 20:05
…ckout-if-one-of-the-products-in-cart-is-not-available-for-pickup
@novikor novikor merged commit e9bfc0e into 1.2-develop Mar 13, 2020
@novikor novikor deleted the MSI-2825-Hide-store-pickup-on-the-Checkout-if-one-of-the-products-in-cart-is-not-available-for-pickup branch March 13, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants