-
Notifications
You must be signed in to change notification settings - Fork 10
Fix PHPcs baseline test failure when there are no files to check #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Vinai i've resolved the issue that occured last friday (the baseline test didn't work on forked repo's). We now have a successfull run: https://github.com/mage-os/mageos-magento2/actions/runs/6149981258/job/16686980485?pr=34. |
|
Thank you, I will review! |
Vinai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the PHPCS baseline tests are failing when there are no files to check. See https://github.com/mage-os/mageos-magento2/actions/runs/5794755408/job/15940229468?pr=32.
What is the new behavior?
composer installstep when phpcs has no files to checkDoes this PR introduce a breaking change?
Additional information
app/code/Magento/Catalog/view/frontend/templates/product/breadcrumbs.phtml, while there are existing errors in breadcrumbs.phtml (that are now in the baseline, so shoudn't be reported).Related PR
mage-os/mageos-magento2#32