Apply Coding standard baseline github action #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprankhub
requested changes
Aug 8, 2023
MeetKamal
commented
Aug 8, 2023
Contributor
Author
MeetKamal
left a comment
MeetKamal
left a comment
There was a problem hiding this comment.
Hi @sprankhub
Have modified the changes, Please review it.
MeetKamal
commented
Aug 8, 2023
Contributor
Author
MeetKamal
left a comment
MeetKamal
left a comment
There was a problem hiding this comment.
Hi @sprankhub
We have modified those changes, please review.
sprankhub
approved these changes
Aug 15, 2023
This was referenced Sep 7, 2023
Closed
Contributor
|
Somehow, I cannot re-run the failing action. @kamleshluhana, could you push an empty commit to trigger the actions again? They should now be green after mage-os/github-actions#115 has been merged. |
Contributor
|
@Tjitse-E, would you mind having a look at the failing action? |
5 tasks
Contributor
|
@sprankhub currently, the old coding standard workflow is failing. In the technical meeting of last week it was decided to remove the current phpcs workflow in favour of the phpcs baseline workflow. Could you review #35? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sprankhub
As discussed on chat, I have created new PR to merge the coding standard baseline integration. For the safer side i have added new yml file in the github work flow.
Please review it.