-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for Swift package manager #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Swift package manager #66
Conversation
This is immensely helpful as I haven’t yet had the time to familiarize myself with the Swift package manager. Thanks a lot; I will review both PRs soon. :) |
Reading Swift Package Manager for plugin authors by Flutter is usually enough. If you have questions regarding any change and why it was introduced, please let me know. |
Alright, I merged it. However, the same issue that’s present in macos_ui (that podfile being mentioned in the readme) is present here as well. I’ll open an issue about it. |
Swift Package Manager support
Support for SPM has already been added to most Flutter plugins and was included in the stable release a while ago. Soon, support for CocoaPods will be deprecated and removed at some point. This PR doesn't remove support for CocoaPods and maintains backward compatibility.
The package macos_ui still depends on appkit_ui_element_colors, which doesn't support the Swift Package Manager yet, but the PR Adrian-Samoticha/appkit_ui_element_colors#2 should fix the issue.
The changes made in this PR follow the Flutter guide for plugin authors.
The example app has been tested with both CocoaPods and SPM. I also ran the following commands:
Related Issues
Other changes
This PR makes some other minor related changes:
AppKit
where needed, this is required by the Swift package manager to access macOS APIs such asNSWindow
.flutter run -d macos
.