add dev-tool #5
Merged
add dev-tool #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hosoai
reviewed
Jun 11, 2023
There was a problem hiding this comment.
ありがとうございます，環境構築が楽になり環境も汚さないのはとてもいいですね！
細かい点ですが少しだけ気になったところをコメントさせて貰いました．
Mac環境下でも @takasehideki に試して貰ってOKそうならMergeしましょう．
|
@s-hosoai これいいですね！CMake 内に取り込んだりできないでしょうか？？ あと個人的には build.bash を標準使用にするのでもいいかなと思っています．Docker環境で走らせたいかは引数なりで使い分けられたらいいかもしれません． |
|
レビュー箇所について修正を行いました。 |
|
修正ありがとうございます！これでマージします |
takasehideki
added a commit
that referenced
this pull request
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provide an excellent development tool 🔨 😎
#4