Skip to content

Commit

Permalink
[bugfix] visualization flickers when rerunning query (apache#6374)
Browse files Browse the repository at this point in the history
When hitting the Query button in the explore view, the previous chart
gets shown (flaskhed quickly) between the moment where the loading
spinner goes away and the new chart show up. This fix seems to prevent
this.

(cherry picked from commit e0b3927)
  • Loading branch information
mistercrunch committed Nov 12, 2018
1 parent fb3d800 commit 8f4500d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion superset/assets/src/chart/Chart.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Chart extends React.PureComponent {

handleRenderSuccess() {
const { actions, chartStatus, chartId, vizType } = this.props;
if (chartStatus !== 'rendered') {
if (['loading', 'rendered'].indexOf(chartStatus) < 0) {
actions.chartRenderingSucceeded(chartId);
}

Expand Down

0 comments on commit 8f4500d

Please sign in to comment.