[bugfix] visualization flickers when rerunning query #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this.
kristw
approved these changes
Nov 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #6374 +/- ##
=======================================
Coverage 77.34% 77.34%
=======================================
Files 67 67
Lines 9583 9583
=======================================
Hits 7412 7412
Misses 2171 2171Continue to review full report at Codecov.
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 12, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 13, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 15, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 15, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 15, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 29, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 30, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 30, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Dec 7, 2018
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 11, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 11, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 11, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 12, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 17, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
xtinec
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 21, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 24, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
When hitting the Query button in the explore view, the previous chart gets shown (flaskhed quickly) between the moment where the loading spinner goes away and the new chart show up. This fix seems to prevent this. (cherry picked from commit e0b3927)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the Query button in the explore view, the previous chart
gets shown (flaskhed quickly) between the moment where the loading
spinner goes away and the new chart show up. This fix seems to prevent
this.