-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for python 3.11 #129
Fix for python 3.11 #129
Conversation
Tested this change out on https://github.com/Orange-Cyberdefense/GOAD, seems to work fine :). |
hmmm, looks like the string conversion isn't quite right... I'll take a look |
Turns out Results in the json are now correct:
Where previously it would return the integer representations of these flags. |
Looks like the Certipy will have these always exist:
Similar to:
However using What should the proper handling of this be? |
Great work! Tested and worked with HTB Escape ;) |
The PR worked for me, thanks a bunch |
This pull request saved me. Thanks heaps. |
Thank you! 🙏🏼 |
This fixes the issue with _decompose calls...
Essentially, if python supports converting the IntFlags into a list, we do it, otherwise we fall back to old behavior.
See #108 for details.