Skip to content

Commit

Permalink
Remove git-dependency (kedro-org#1284)
Browse files Browse the repository at this point in the history
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
  • Loading branch information
antonymilne authored and lvijnck committed Apr 7, 2022
1 parent b3d9f1a commit 327c36d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Fixed slow startup because of catalog processing by reducing the exponential growth of extra processing during `_FrozenDatasets` creations.
* Removed `.coveragerc` from the Kedro project template. `coverage` settings are now given in `pyproject.toml`.
* Fixed a bug where packaging or pulling a modular pipeline with the same name as the project's package name would throw an error (or silently pass without including the pipeline source code in the wheel file).
* Removed unintentional dependency on `git`.

## Minor breaking changes to the API

Expand Down
5 changes: 4 additions & 1 deletion kedro/framework/cli/starters.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
from typing import Any, Callable, Dict, List, Optional, Tuple

import click
import git
import yaml

import kedro
Expand Down Expand Up @@ -410,6 +409,10 @@ def validate(self, user_input: str) -> None:


def _get_available_tags(template_path: str) -> List:
# Not at top level so that kedro CLI works without a working git executable.
# pylint: disable=import-outside-toplevel
import git

try:
tags = git.cmd.Git().ls_remote("--tags", template_path.replace("git+", ""))

Expand Down

0 comments on commit 327c36d

Please sign in to comment.