Skip to content

Commit

Permalink
Remove .coveragerc from project template (kedro-org#1282)
Browse files Browse the repository at this point in the history
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
  • Loading branch information
antonymilne authored and lvijnck committed Apr 7, 2022
1 parent 70cac64 commit b3d9f1a
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 18 deletions.
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* Relaxed the bounds on the `plotly` requirement for `plotly.PlotlyDataSet`.
* `kedro pipeline package <pipeline>` now raises an error if the `<pipeline>` argument doesn't look like a valid Python module path (e.g. has `/` instead of `.`).
* Fixed slow startup because of catalog processing by reducing the exponential growth of extra processing during `_FrozenDatasets` creations.
* Removed `.coveragerc` from the Kedro project template. `coverage` settings are now given in `pyproject.toml`.
* Fixed a bug where packaging or pulling a modular pipeline with the same name as the project's package name would throw an error (or silently pass without including the pipeline source code in the wheel file).

## Minor breaking changes to the API
Expand Down
2 changes: 1 addition & 1 deletion docs/source/03_tutorial/02_tutorial_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jupyter_client>=5.1.0, <7.0 # Used to open a Kedro-session in Jupyter Notebook &
jupyterlab~=3.0 # Used to open a Kedro-session in Jupyter Lab
kedro==0.17.5
nbstripout~=0.4 # Strips the output of a Jupyter Notebook and writes the outputless version to the original file
pytest-cov~=2.5 # Produces test coverage reports
pytest-cov~=3.0 # Produces test coverage reports
pytest-mock>=1.7.1, <2.0 # Wrapper around the mock package for easier use with pytest
pytest~=6.2 # Testing framework for Python code
wheel>=0.35, <0.37 # The reference implementation of the Python wheel packaging standard
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ known_third_party = "kedro"
addopts = """
--cov-report term-missing \
--cov src/{{ cookiecutter.python_package }} -ra"""

[tool.coverage.report]
fail_under = 0
show_missing = true
exclude_lines = ["pragma: no cover", "raise NotImplementedError"]
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jupyterlab~=3.0
kedro[pandas.CSVDataSet]=={{ cookiecutter.kedro_version }}
kedro-telemetry~=0.1.0
nbstripout~=0.4
pytest-cov~=2.5
pytest-cov~=3.0
pytest-mock>=1.7.1, <2.0
pytest~=6.2
wheel>=0.35, <0.37

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ known_third_party = "kedro"
addopts = """
--cov-report term-missing \
--cov src/{{ cookiecutter.python_package }} -ra"""

[tool.coverage.report]
fail_under = 0
show_missing = true
exclude_lines = ["pragma: no cover", "raise NotImplementedError"]
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jupyterlab~=3.0
kedro=={{ cookiecutter.kedro_version }}
kedro-telemetry~=0.1.0
nbstripout~=0.4
pytest-cov~=2.5
pytest-cov~=3.0
pytest-mock>=1.7.1, <2.0
pytest~=6.2
wheel>=0.35, <0.37
3 changes: 1 addition & 2 deletions test_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ biopython~=1.73
black==21.5b1
blacken-docs==1.9.2
compress-pickle[lz4]~=1.2.0
coverage[toml]
dask[complete]~=2.6
dill~=0.3.1
gcsfs>=2021.04, <2022.01 # Upper bound set arbitrarily, to be reassessed in early 2022
Expand All @@ -33,7 +32,7 @@ pyarrow>=0.12.0, <4.0
pylint>=2.5.2, <3.0
pyproj>=2.2.0, <3.0 # pyproj 3.0 requires proj>=7.2 but that conflicts with fiona which requires proj<7.2.
pyspark>=2.2, <4.0
pytest-cov~=2.5
pytest-cov~=3.0
pytest-mock>=1.7.1, <2.0
pytest-xdist[psutil]~=2.2.1
pytest~=6.2
Expand Down
2 changes: 1 addition & 1 deletion tests/framework/cli/test_starters.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
from kedro import __version__ as version
from kedro.framework.cli.starters import _STARTER_ALIASES, TEMPLATE_PATH

FILES_IN_TEMPLATE = 36
FILES_IN_TEMPLATE = 35


@pytest.fixture
Expand Down

0 comments on commit b3d9f1a

Please sign in to comment.