-
Notifications
You must be signed in to change notification settings - Fork 154
Add Keypoints message type and expand dai::ImgDetection with dai::RotatedRect and dai::Keypoints #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aljazkonec1
wants to merge
23
commits into
develop
Choose a base branch
from
dev_img_detections_update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is the first port of depthai-nodes ImgDetectionsExtended (link) and Keypoints (link) messages into the core library.
An example of using new ImgDetections + Keypoints can be found on this branch.
Specification
dai::RotatedRect
, used for converting the stored rectangle to the other popular YOLO and VOC bounding box representation types.Point3f coordinates
,float confidence
,int label
andstring labelName
.dai::Keypoint
objects, a vector of possible edge idices between Keypoints and provides utility functions for faster and easier conversions betweendai::Keypoints
types and other common types likedai::Point3f
/dai::Point2f
.dai::KeypointsList
.dai::ImgDetection
:dai::RotatedRect
as a fielddai::KeypointsList
as fieldxmin, ymin, xmax, ymax
format and newdai::RotatedRect
fields are synced and current implementations of ImgDetections still work.Dependencies & Potential Impact
Potential risks include already built pipelines that rely on
dai::ImgDetections
.Testing & Validation
Tested on this branch. Two annotations are seen.
detections
topic sends dai::ImgDetections directly to visualizer and visualizer handles annotating it.modified_annotations
is a modified version where rotation and keypoints are also taken into account when visualizing a bounding box. Tested only on RVC4.