transform: Add output directory optional argument #610
+107
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieetang
reviewed
Nov 21, 2025
Contributor
annieetang
left a comment
annieetang
left a comment
There was a problem hiding this comment.
is this creating the output file as the same name as the original file? do you think we could add an option to specify the specific output file name as well? in case users want to specify the file name differently too
Contributor
Author
I considered it, but |
annieetang
approved these changes
Nov 21, 2025
Contributor
annieetang
left a comment
annieetang
left a comment
There was a problem hiding this comment.
lgtm, but I'd defer to maybe @hgoldstein for a check to see if it works with the external ask?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #607
Rather than specifying a single output file as requested, I decided to allow specifying a directory instead, since
lute transformcan take any number of files to be transformed.