Fix static HTML class list navigation path duplication (#1639)#1647
Open
carsonclarkemagrab-toast wants to merge 1 commit intolsegal:mainfrom
Open
Conversation
Fixes incorrect URL resolution in fetch-based navigation that caused nested class links to duplicate parent paths (e.g., /Foo/Foo/Baz.html instead of /Foo/Baz.html) when serving static HTML documentation. The issue occurred because relative URLs from the class list iframe were being resolved against the main frame's current URL instead of the iframe's base URL. This fix resolves URLs correctly by using the iframe's location as the base for relative path resolution. Related: block/elasticgraph#1048 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Seems like I opened this right after a fix put up in another PR: #1646 |
carsonclarkemagrab-toast
added a commit
to carsonclarkemagrab-toast/elasticgraph
that referenced
this pull request
Feb 25, 2026
YARD 0.9.38 has a bug that breaks documentation generation (lsegal/yard#1639). This fix has been submitted upstream (lsegal/yard#1647). In the meantime, we exclude 0.9.38 from our dependency constraint, allowing bundler to use 0.9.37 or (once released) 0.9.39+. This also regenerates the v1.1.0 documentation archive with YARD 0.9.37 to fix the broken docs that were generated with 0.9.38. Resolves block#1048 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
carsonclarkemagrab-toast
added a commit
to carsonclarkemagrab-toast/elasticgraph
that referenced
this pull request
Feb 25, 2026
YARD 0.9.38 has a bug that breaks documentation generation (lsegal/yard#1639). This fix has been submitted upstream (lsegal/yard#1647). In the meantime, we exclude 0.9.38 from our dependency constraint, allowing bundler to use 0.9.37 or (once released) 0.9.39+. This also regenerates the v1.1.0 documentation archive with YARD 0.9.37 to fix the broken docs that were generated with 0.9.38. Resolves block#1048 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1639
This fixes a breaking bug in v0.9.38 where clicking nested class links in the class list generates incorrect URLs when serving static HTML documentation, resulting in 404 errors.
Root Cause
The fetch-based navigation system (commit e18b844) resolves relative URLs from the class list iframe against the main frame's current URL instead of the iframe's base URL. When viewing
/Foo/Bar.htmland clicking a link toFoo/Baz.html, the browser incorrectly resolves it as/Foo/Foo/Baz.html.The Fix
contentWindow.locationinstead of the main frame locationFoo/Baz.htmlresolve correctly regardless of the current pageTesting
Reproduced the issue with nested class structure:
Related: block/elasticgraph#1048