fix: relative URL resolution for client-side docs navigation#1646
Open
GunniBusch wants to merge 1 commit intolsegal:mainfrom
Open
fix: relative URL resolution for client-side docs navigation#1646GunniBusch wants to merge 1 commit intolsegal:mainfrom
GunniBusch wants to merge 1 commit intolsegal:mainfrom
Conversation
GunniBusch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidebar navigation links are generated as relative URLs that work from the docs root, but they break when the current page is under a nested path.
This change uses the existing
relpathvalueyard/templates/default/layout/html/script_setup.erb
Line 3 in eddd10c
rel_url = relpath + e.data.url) and then uses that resolved URL consistently during navigation.Please see the homebrew ruby docs as an example: https://docs.brew.sh/rubydoc/Formula/FormulaConflict.html. From this class try going to any other class. Also see Homebrew/brew#21589