Open
Description
openedon Mar 3, 2023
Description
This issue is related to #17416
@jadephilipoom made some good points on the batch mode implementation in the ecc256_keygen_serial.c file, which are also valid to each batch mode implementation in the other serial files. Hence, these suggested modifications should be applied to every serial file.
The points are:
- To fully comply with the style guide.
- To remove the global key/message/seed/etc. arrays, which store all values from each batch, and instead allocate enough stack memory locally for a single key/message/seed/etc. value. If we then directly process each single value this would allow us to remove the maximum number of traces per batch and also the second for-loop.
- To use
memcpy(num_traces, data, data_len)
instead ofnum_traces = read_32(data)
. This is safer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Issue related to SoftwareIssue related to SoftwareTemporary label to triage issues into Earlgrey-PROD MilestonesTemporary label to triage issues into Earlgrey-PROD MilestonesPriority: mediumPriority: mediumCleanup tasksCleanup tasksFeature requests, enhancementsFeature requests, enhancements