-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sw/sca] Add batch mode for ecc256 keygen serial file #17416
Conversation
We just discussed in the SCA WG meeting that I, for now, should only address the objections relevant to this individual batch mode implementation. This allows us to progress faster with the actual TVLA analysis. For all the other issues, which concern the other batch modes too, I will open up an issue in the OT repository, so that the comments @jadephilipoom made won't get lost. Thanks for the extensive review @jadephilipoom ! |
aaa2f15
to
317a055
Compare
Adds a command handler to set a signal value whether masking should be enabled/disabled for secret keygen in batch mode Adds a command handler for the batch mode itself Signed-off-by: Moritz Wettermann <moritz.wettermann@gi-de.com>
317a055
to
8b33b4e
Compare
I now also opened A PR in the ot-sca repository, which adds the corresponding batch mode capture function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am merging this PR despite the "Earl Grey SW Build & Test" currently fails. The failure is due to the step timing out. A PR to increase the timout is under way (see #17440). However, this PR here doesn't change any software that is run in CI or on the Verilated platform. Instead, the SCA-related binaries are just compiled and there are no compilation failures. It is thus safe to merge this PR here. |
This commit / PR
The binary that can be built from this code is required for capturing traces in batch mode for OTBN ecc256 keygen vertical TVLA analysis.