Merge from mrniko/netty-socketio master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If an endpoint receives a Close frame and did not previously send a Close frame, the endpoint MUST send a Close frame in response.
[#547] process websocket CloseFrame
fix memory leak issue
Fix concurrency issue
#596 reason: WebSocketTransport line 144 : Packet packet = new Packet(PacketType.MESSAGE); //subType =null PacketEncoder line 288: byte subType = toChar(packet.getSubType().getValue()); //NullPointerException fix WebSocketTransport Packet packet = new Packet(PacketType.MESSAGE); packet.setSubType(PacketType.MESSAGE);
fix null point
fix NPE & mem leak
socketio.js 2.0 + netty-socketio-1.7.16 reason: namespace request payload contains url query string info, like `8:40/chat,` `49:40/chatroom?uid=ba7822bee25940ada9d2a987670afc5d,` it does'n match `/chat` or `/chatroom` in namespacehub fix: sub the query string
fix invalid namespace
Fix #593: add randomSession config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.