fix memory leak issue #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, there is memory leak issue in our prod environment. We analyzed the heap dump, and found that the ClientsBox consumed huge memory. Inactive Channels had not be released from ClientsBox. |
|
Would you review my comments? |
|
Where 's your comments? |
mrniko
reviewed
Jul 4, 2018
| log.debug("channel inactive {}", client.getSessionId()); | ||
| client.onChannelDisconnect(); | ||
| } | ||
| channel.close(); |
There was a problem hiding this comment.
@dawnbreaks You don't need to invoke channel close() method.
dawnbreaks
force-pushed
the
master
branch
3 times, most recently
from
bc2ac28 to
664df09
Compare
|
Hi, please review the code again, thanks very much. |
mrniko
approved these changes
Jul 4, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release inactive long-polling channel from ClientsBox to avoid memory leak