Repository navigation
chore(ci): remove the OrcaCode pull-request review workflow - #180
Conversation
The OrcaCode Review action reported a failed check on every pull request and never once succeeded: of 132 runs since it was introduced in #172, none completed. Two separate faults sat behind that, neither in this repository: 1. The configured OrcaRouter router selected no model for the review engine's requests. The engine sends six function tools on every file review, and the router's allowed models were all `-free` ids, which carry no capability metadata in OrcaRouter's catalog (no `supported_endpoint_types`, no `context_length`). With no eligible candidate and no `default_model`, the router returned HTTP 400 before any model saw the request. 2. After a paid model was added to the router, the review ran (54 calls, 0.5M prompt tokens, no rejections) but still failed closed: four upstream calls went unanswered, one file's review failed, and the action treats any partial result as unusable. Diagnosing either from CI was impractical. The action surfaces the upstream response only when its internal proxy fails to start, so a 400 from the router is discarded, and the engine prints the same generic "check your LLM configuration and API key" for every failure mode -- reproduced locally with a deliberately invalid key. The partial-result path then renders its warnings with `warnings.join("; ")` over objects, so the reason reached the log as `[object Object]`. Removed with the workflow: - the paragraph in CONTRIBUTING.md describing the automatic review and its `/orcacode-review` comment trigger, which no longer exists; - the `workflowPolicy` test that pinned the workflow's gating and action pin. Its sibling tests derive their file list from `readdirSync`, so they need no change and still cover the remaining workflows. Impact: `review` was never a required status check on `main`, so no merge condition changes and no open pull request is blocked. The `ORCAROUTER_API_KEY` repository secret is now unused; it is left in place to be deleted separately rather than removed from under any other consumer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @looptroop-ai, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 2 days and 3 hours by commenting @sourcery-ai review. Upgrade to get a review now.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the consistently failing, non-required OrcaCode review workflow, cleans up its documentation and policy test, and records the operational rationale and impact in the changelog. Remaining workflow policy coverage is preserved, while the repository secret is intentionally left for separate verification and removal. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each action level your way: inline, summary, both, or drop |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR removes the OrcaCode review workflow, its contributor guidance, and its workflow policy test. The changelog records the removal and the workflow’s failed runs. ChangesOrcaCode review removal
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This change removes a consistently failing, non-required review workflow and its obsolete documentation without changing required merge conditions. It is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoRemove the failing OrcaCode pull-request review workflow
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review ✅ Approved🟡 Medium risk · Removes pull-request review automation and its policy coverage, altering CI behavior Removes the nonfunctional OrcaCode pull-request review workflow that never succeeded in 132 runs, along with references in OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 2 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes look good and are ready to merge. This PR adds validation testing for mixed read/write workflows, updates the changelog for v0.0.15, and enhances the contributing guide with connector configuration export instructions. All changes follow established patterns and coding standards.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
 |
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by free · Input: 0 · Output: 0 · Cached: 0 |
|
Claude Opus 5 — review of 1. The CHANGELOG's run statistics are contradicted by the run history.
"never completed a successful run" is accurate (zero 2. 3. The Summary line should not be there. 4. The 5. Cross-PR collision with #179 on
6. This removes the repository's only first-party automated review pass. Nothing in this PR replaces it, and that is not stated anywhere in the diff. In practice CodeRabbit and Sourcery both review this very PR, so the loss is not total — but if the intent is that third-party bots are the replacement, say so in the 7. Verified clean, so as not to be re-litigated: there is no dangling reference anywhere — 🤖 Generated with Claude Code |
Antigravity — Code Review Findings & Recommendations1. Repository Secret CleanupThe workflow file
2. Rebase Required for In-Flight PRsBranches created before this change (such as open PRs #178 and #179) still contain
3. Changelog Placement Under User-Facing SummaryIn - The OrcaCode pull-request review workflow is removed; it reported a failed check on every pull request and never completed a successful run.
4. Generic Policy Test for Untrusted PR TriggersThe removed test in
|
|
Muse Spark review — no open findings. Verified: workflow file, |
|
opencode 1. "A failed check on every pull request" overstates the run historyWhere: Evidence:
Suggestion: Reword both changelog lines and the PR description to what the data supports — e.g. "produced 22 failed checks across six pull-request branches and never once succeeded" — instead of claiming every pull request got a red check. 2. "of 132 runs" was already stale when the commit landedWhere: Evidence: run
Also, "none completed" is wrong in a literal reading: every run has Suggestion: Use the final figure ("168 runs, none succeeded") or drop the count entirely; keep "never succeeded", drop "none completed". Same fix applies to the PR description. 3.
|
1 participant
Removes
.github/workflows/orcarouter-code-review.ymland everything that referenced it.Why
The OrcaCode Review action put a red check on every pull request and never once succeeded — of 132 runs since it was introduced in #172, none completed. Two separate faults sat behind that, neither of them in this repository:
-freeids, which carry no capability metadata in OrcaRouter's catalog — nosupported_endpoint_types, nocontext_length. With no eligible candidate and nodefault_model, every call came backHTTP 400: strategy selected nothing for router 'orcacode-review' and no default_model set, before any model saw the request.warningsas unusable.Diagnosing either from CI was impractical. The action surfaces the upstream response only when its internal proxy fails to start, so a 400 from the router is discarded; the engine prints the same generic
check your LLM configuration and API keyfor every failure mode (reproduced locally with a deliberately invalid key); and the partial-result path renders its warnings withwarnings.join("; ")over objects, so the actual reason reached the log as[object Object].Also removed
CONTRIBUTING.mddescribing the automatic review and its/orcacode-reviewcomment trigger, which no longer exists.workflowPolicytest that pinned the workflow's gating and action SHA. Its sibling tests build their file list fromreaddirSync, so they need no change and still cover the remaining workflows.Impact
reviewwas never a required status check onmain(confirmed against the branch protection API), so no merge condition changes and no open pull request is blocked by this.The
ORCAROUTER_API_KEYrepository secret is now unused. It is deliberately left in place rather than deleted from under any other consumer — worth removing separately once you're sure nothing else reads it.Checks
npx vitest run tests/workflowPolicy.test.ts— 14 passednpm run typecheck— cleannpx eslint tests/workflowPolicy.test.ts— clean🤖 Generated with Claude Code
Summary by Sourcery
Remove the nonfunctional OrcaCode pull-request review workflow and all repository references to it.
Enhancements:
CI:
Documentation:
Tests:
Chores:
Summary by CodeRabbit
Chores
Documentation